Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another aspect of synchronizing XProc's document property 'base-uri' and documents base uri property #897

Closed
xml-project opened this issue Nov 4, 2019 · 4 comments
Assignees

Comments

@xml-project
Copy link
Contributor

@xml-project xml-project commented Nov 4, 2019

This is related to #889 , but as I do not want to interfere with @gimsieke's work on this, I raised an new issue:

Currently (to my understanding) we say, that if a document has no base-uri, the 'base-uri' key in the document properties document is not present. I think we should change that, saying that the 'base-uri' property is always present, but associated with the empty sequence for documents without a base uri.

This approach is more in line with XPath's approach to the document URI property.

@gimsieke

This comment has been minimized.

Copy link
Contributor

@gimsieke gimsieke commented Nov 9, 2019

No objection

@xatapult

This comment has been minimized.

Copy link
Contributor

@xatapult xatapult commented Nov 9, 2019

Main reason: p:document-property() function usage.

We decide against it. If a document does not have a base-uri the document-properties map does not have a base-uri entry.

@xatapult

This comment has been minimized.

Copy link
Contributor

@xatapult xatapult commented Nov 9, 2019

Still have to clarify what the word optional means for the base-uri property.

@ndw

This comment has been minimized.

Copy link
Contributor

@ndw ndw commented Nov 9, 2019

Fixed by #903

@ndw ndw closed this Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.