Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples in https://spec.xproc.org/master/head/xproc/#parallelism seem to be incomplete #938

Closed
martin-honnen opened this issue Jan 25, 2020 · 3 comments

Comments

@martin-honnen
Copy link

@martin-honnen martin-honnen commented Jan 25, 2020

When reading https://spec.xproc.org/master/head/xproc/#parallelism I am a bit puzzled, it says "consider the following pipeline" and shows the snippet

<p:xslt name="generate-stylesheet">
    <p:with-input port="source" href="someURI"/>
    <p:with-input port="stylesheet" href="someOtherURI"/>
  </p:xslt>

  <p:store name="save-xslt" href="gen-style.xsl"/>

Later on it seems to show the exact same snippet but says "Now the result is independent of the implementation strategy".

I have tried to look at the source and it seems it uses XInclude in https://github.com/xproc/3.0-specification/blob/master/xproc/src/main/xml/parallel.xml with two different files but somehow the section in the complete spec cuts off the last part of the two examples so that they both end up looking the same.

@xml-project

This comment has been minimized.

Copy link
Contributor

@xml-project xml-project commented Jan 25, 2020

Right, the examples are broken because a third step (which makes the difference) is missing. The original example comes from the 1.0 specs: https://www.w3.org/TR/xproc/#parallelism
I will fix this. Thanks for finding.

@xml-project

This comment has been minimized.

Copy link
Contributor

@xml-project xml-project commented Jan 25, 2020

Here are my findings: As far as I understand the build process, the files

  • "../../../build/examples/par1.txt"

  • ../../../build/examples/par1b.txt"

are created from

  • "3.0-specification/xproc/src/main/examples/par1.xml"
  • "3.0-specification/xproc/src/main/examples/par1b.xml"

The later seems to be correct, so something in the build process is broken causing the last steps in the "xml"-documents not to be copied in the "txt"-documents.
As I am not completly familar with the whole build process, this is someting @ndw has to look in.

@ndw

This comment has been minimized.

Copy link
Contributor

@ndw ndw commented Jan 25, 2020

Fixed. (Or "fixing" as I expect the update is still building at the moment.) Thank you!

@ndw ndw closed this Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.