New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing step's signature of p:cast-content-type #567

Merged
merged 1 commit into from Oct 18, 2018

Conversation

Projects
None yet
3 participants
@xml-project
Contributor

xml-project commented Oct 18, 2018

Attempt to fix #566

@xml-project xml-project requested review from ndw, gimsieke and eriksiegel Oct 18, 2018

@gimsieke

I’m wondering whether there is no “standard library steps RNC” yet that would need to be adjusted accordingly

@xml-project

This comment has been minimized.

Contributor

xml-project commented Oct 18, 2018

@gimsieke Thanks for the hint: Will check and ask @ndw in case of emergency.

@ndw

This comment has been minimized.

Contributor

ndw commented Oct 18, 2018

The steps.xpl file (http://spec.xproc.org/master/head/steps/steps.xpl) is build automatically from the descriptions in the spec.

@ndw

ndw approved these changes Oct 18, 2018

@xml-project

This comment has been minimized.

Contributor

xml-project commented Oct 18, 2018

@ndw So there is no RNG or RNC I have to change, if I change the step's signature?

@ndw

This comment has been minimized.

Contributor

ndw commented Oct 18, 2018

Correct. If you look in your build/dist/steps directory, you'll find the correct version built from your spec change.

@xml-project xml-project merged commit 2787f5e into xproc:master Oct 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xml-project xml-project deleted the xml-project:fix-566 branch Oct 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment