New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework description of common attributes #577

Merged
merged 4 commits into from Oct 24, 2018

Conversation

Projects
None yet
3 participants
@ndw
Contributor

ndw commented Oct 24, 2018

This my attempt to implement what we decided to do about 554. I believe it also closes 29.

Fix #554
Fix #29

ndw added some commits Oct 24, 2018

@ndw ndw requested review from gimsieke, eriksiegel and xml-project Oct 24, 2018

@xml-project

This comment has been minimized.

Contributor

xml-project commented Oct 24, 2018

@ndw We broke it. In my PR from yesterday I moved "common attributes" one level up, so there would be two sections in this document.

With your PR you remove to section completely and now there is a conflict. I do not dare trying to resolve it (because I have never done this be before). Can you please fix it?

@xml-project

This comment has been minimized.

Contributor

xml-project commented Oct 24, 2018

@ndw Thanks!

@ndw ndw merged commit e735748 into xproc:master Oct 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ndw ndw deleted the ndw:p-attributes branch Oct 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment