Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework section 3.1, document types #604

Merged
merged 4 commits into from Nov 1, 2018
Merged

Rework section 3.1, document types #604

merged 4 commits into from Nov 1, 2018

Conversation

ndw
Copy link
Contributor

@ndw ndw commented Oct 31, 2018

Fix #588.

xml-project
xml-project reviewed Oct 31, 2018
View reviewed changes
Copy link
Member

@xml-project xml-project left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I am not finally convinced whether the handling of text/html (constructed inline) will wrong, but I think we should give it a try.
  2. I do not like the fact, that a text document is not a text document wrapped in a document node anymore. Do we really need this change?

@ndw
Copy link
Contributor Author

ndw commented Oct 31, 2018

Let me do a little updating.

@ndw
Copy link
Contributor Author

ndw commented Oct 31, 2018

You can see the formatted text here: http://xpspectest.nwalsh.com/iss-588/head/xproc/#document-types

@ndw ndw merged commit 207edbe into xproc:master Nov 1, 2018
@ndw ndw deleted the iss-588 branch November 1, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xml-project xml-project xml-project approved these changes

@gimsieke gimsieke Awaiting requested review from gimsieke

@xatapult xatapult Awaiting requested review from xatapult

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ndw @xml-project