New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix 597 #621

Merged
merged 1 commit into from Nov 3, 2018

Conversation

Projects
None yet
2 participants
@xml-project
Contributor

xml-project commented Nov 2, 2018

Removed requirement that the p:catch clauses have to be considered in document order. The only order requirement now is, that the p:catch without a code-attribute has to be the last.
I think that is reasonable and will enforce good coding practice, but I am open to the argument, that should just enforce that there is only one p:catch without code-attribute, wherever it may appear in the sequence.

@xml-project xml-project requested review from ndw, gimsieke and eriksiegel Nov 2, 2018

@ndw

This comment has been minimized.

Contributor

ndw commented Nov 2, 2018

I definitely think we should require the catch without a code to be last.

@ndw

ndw approved these changes Nov 2, 2018

@xml-project xml-project merged commit f4705b4 into xproc:master Nov 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xml-project xml-project deleted the xml-project:fix-597 branch Nov 3, 2018

@xml-project xml-project referenced this pull request Nov 3, 2018

Closed

p:catch order #597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment