New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructuring of variables and options section #681

Merged
merged 1 commit into from Jan 2, 2019

Conversation

Projects
None yet
3 participants
@eriksiegel
Contributor

eriksiegel commented Dec 31, 2018

Based on #673 I did some editing on the variables and options section to make it more consistent and logical. Mostly changes on the section structure.

  • The QName handling section is still part of the options and variables overarching section. @xml-project suggested it should be taken out and become a section of its own. I suggest we leave it here for now, taking it out is now easy if we decide to.
  • I also edited the section on static variables and options which I think was incorrect.
@xml-project

This comment has been minimized.

Contributor

xml-project commented Dec 31, 2018

Because you did a lot of editing, the diffs are very difficult to understand. Could you please post a link to the formatter version?

@eriksiegel

This comment has been minimized.

Contributor

eriksiegel commented Dec 31, 2018

Ehh, I would like to. Not sure that I have one, sorry. I have no idea how that mechanism works but if anyone can help me set it up I'll implement it asap.

@eriksiegel

This comment has been minimized.

Contributor

eriksiegel commented Dec 31, 2018

index.zip
Poor man's substitute for publishing the pages...

@xml-project

This comment has been minimized.

Contributor

xml-project commented Dec 31, 2018

If I commit a PR there is a folder with the branch's name in the ghpages brach of my repo representing the formatter version. I haven't found any in you repo, so I thought you have changed the mechanism. May be @ndw can help out later.

@xml-project
Contributor

xml-project left a comment

Looks good to me. But I fail to see how the initial problem is solved, that QName-magic and key-QName-magic is not only apply to p:option and p:variable, but also to attributes on xproc elements like p:output/@serialization or p:with-input/p:inline/@document-properties.

@xml-project xml-project requested review from gimsieke and ndw Dec 31, 2018

@xml-project

This comment has been minimized.

Contributor

xml-project commented Jan 1, 2019

What about this?

  1. We merge Erik's rework, which improves clarity of our concepts a lot.
  2. We edit the first list in section "Syntax summaries" saying that the mechanism described in Erik's section 11.5 (QName handling) applies, if an attribute is marked as AVT with type "QName" or is marked with a sequence type expression.
@ndw

This comment has been minimized.

Contributor

ndw commented Jan 2, 2019

I agree these changes are an improvement, we should merge them. What @xml-project proposes for the "Syntax summaries" section sounds plausible to me, but I haven't given it a great deal of thought.

@ndw

ndw approved these changes Jan 2, 2019

@eriksiegel

This comment has been minimized.

Contributor

eriksiegel commented Jan 2, 2019

@ndw ndw merged commit c056143 into xproc:master Jan 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ndw

This comment has been minimized.

Contributor

ndw commented Jan 2, 2019

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment