New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markup issues in p:urify() #688

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@ndw
Contributor

ndw commented Jan 3, 2019

This PR just makes a few small markup and editorial improvements to the p:urify() function.

  1. In order to gather implementation defined/dependent bits in an appendix, you have to wrap the statement in an <impl> tag.
  2. In order to make the bits in the appendix understandable, you have to write them as sentences that will stand alone, out of context.
  3. I fixed the section title so it's more in line with the others.

@ndw ndw requested review from gimsieke , eriksiegel and xml-project Jan 3, 2019

@ndw

This comment has been minimized.

Contributor

ndw commented Jan 3, 2019

Sorry, I also made one ostensibly non-editorial change. I made the algorithm used implementation-defined rather than implementation-dependent.

@ndw ndw merged commit 9c553be into xproc:master Jan 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment