New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix another markup problem #729

Merged
merged 1 commit into from Jan 26, 2019

Conversation

Projects
None yet
2 participants
@ndw
Copy link
Contributor

ndw commented Jan 26, 2019

Sorry I missed this in the earlier PR. There was a markup error (a glossterm'd static-error that wasn't in an error element) and that made me look more closely at the paragraph.

I've reworded it slightly to improve the English.

I have a question though, why is the case of type errors being called out specifically here. We have a rule that says dynamic errors can be raised statically if the processor can prove they will always occur, does that rule not apply to type errors? If not, why not?

@ndw ndw requested review from gimsieke , eriksiegel and xml-project Jan 26, 2019

@xml-project

This comment has been minimized.

Copy link
Contributor

xml-project commented Jan 26, 2019

  1. Sorry for the markup-error.
  2. Thanks for improving my English. Punctuation is really the worst part of it.
  3. I think we need to call out type error in XPath expression as I did, because a conformant XPath processor may either report typing errors statically, or report them dynamically. In the specs this is called "Static typing feature" and its optional.

If we do not call out type error here the behaviour of a pipeline changes if you switch from Saxon EE (static typing feature implemented -> typing error raised statically) to Saxon HE (error raised dynamically).

Did I miss something?

@ndw

This comment has been minimized.

Copy link
Contributor Author

ndw commented Jan 26, 2019

No, thanks, I think that's worth highlighting.

@ndw ndw merged commit de3d3d7 into xproc:master Jan 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ndw ndw deleted the ndw:fix-more-errors branch Jan 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment