Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #847 by making the error port primary #848

Merged
merged 1 commit into from Jul 22, 2019

Conversation

@ndw
Copy link
Contributor

commented Jul 22, 2019

I think this is the simplest resolution.

@ndw ndw requested a review from xproc/spec-authors as a code owner Jul 22, 2019

@xml-project

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

@ndw The following tests of the test suite need to be changed as a result:

  • ab-drp-context-004
  • ab-drp-context-014
  • ab-drp-context-015
  • ab-drp-context-023
@ndw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 22, 2019

I created xproc/3.0-test-suite#228 to track the test changes. Can't (reliably) check those until I change my implementation :-)

Feel free to fix them first if you get to them before I do.

@ndw ndw merged commit b7bb616 into xproc:master Jul 22, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ndw ndw deleted the ndw:iss-847 branch Jul 22, 2019

@xml-project

This comment has been minimized.

Copy link
Contributor

commented Jul 22, 2019

@ndw Will do tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.