Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to resolve static options and variables #864

Merged
merged 1 commit into from Sep 2, 2019

Conversation

@ndw
Copy link
Contributor

commented Sep 2, 2019

If accepted, this will fix #826.

@ndw ndw requested review from gimsieke, eriksiegel and xml-project Sep 2, 2019

@ndw ndw requested a review from xproc/spec-authors as a code owner Sep 2, 2019

@eriksiegel
Copy link
Contributor

left a comment

Its hard for me to judge, but I trust you on this. If it still contains mistakes, we can fix them later.

@xml-project
Copy link
Contributor

left a comment

At a first glance it looks good to me. As @eriksiegel proposed: Merge it and let's see what happens, if we read it in context.

@ndw ndw merged commit d1af301 into xproc:master Sep 2, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ndw ndw deleted the ndw:iss-826b branch Sep 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.