Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shot at 889 #890

Merged
merged 2 commits into from Oct 22, 2019

Conversation

@xml-project
Copy link
Contributor

xml-project commented Oct 20, 2019

First shot at #889 (only core specs). Changes on p:load and p:set-properties (step specs) are pending.

Does this work to clarifiy the relation and to solve the synch problem?

@xml-project xml-project requested review from ndw, gimsieke and xatapult Oct 20, 2019
@xml-project xml-project requested a review from xproc/spec-authors as a code owner Oct 20, 2019
Copy link
Contributor

gimsieke left a comment

So far, so good.

In the core spec, there needs to be additional clarity what the base-uri key of p:document/@document-properties does to the base URI of the read document (it should set the base URI to the value associated with the base-uri key).

And I suggest that we add a sentence to § 14.3 Base URIs and xml:base, for example:

The base URI of a document node may be manipulated by changing the base-uri document property.

@xml-project

This comment has been minimized.

Copy link
Contributor Author

xml-project commented Oct 20, 2019

Let's see what @ndw and @eriksiegel have to say.

@gimsieke

In the core spec, there needs to be additional clarity what the base-uri key of p:document/@document-properties does to the base URI of the read document (it should set the base URI to the value associtated with the base-uri key).

As we decided to define p:document completely via p:load, I think the clarification there should also contribute to the case you mentioned.

document. If no such key is present, the document has no base URI. The processor is
responsible for assuring that the <code>base-uri</code> property matches the base URI
of each document produced on every output port.</para>
document. For XML document, HTML documents, and text documents, the value of “<code>base-uri</code>”

This comment has been minimized.

Copy link
@ndw

ndw Oct 21, 2019

Contributor

"For XML documents, HTML ..."

@ndw

This comment has been minimized.

Copy link
Contributor

ndw commented Oct 21, 2019

Looks ok to me.

@ndw
ndw approved these changes Oct 21, 2019
@xml-project xml-project merged commit 40e6ecb into xproc:master Oct 22, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xml-project

This comment has been minimized.

Copy link
Contributor Author

xml-project commented Oct 22, 2019

Will supply the second half (p:load / p:set-properties) this afternoon.

@xml-project xml-project deleted the xml-project:shot-at-889 branch Oct 22, 2019
This was referenced Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.