Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define the scope of static option names #913

Merged
merged 2 commits into from Nov 18, 2019
Merged

Define the scope of static option names #913

merged 2 commits into from Nov 18, 2019

Conversation

@ndw
Copy link
Contributor

ndw commented Nov 17, 2019

Fix #868

@ndw ndw requested review from gimsieke, xatapult and xml-project Nov 17, 2019
@ndw ndw requested a review from xproc/spec-authors as a code owner Nov 17, 2019
Copy link
Contributor

xatapult left a comment

You don't mention that static options in libraries can be be private. I think that concept needs to be mentioned here.

@ndw

This comment has been minimized.

Copy link
Contributor Author

ndw commented Nov 18, 2019

Good point. We don't mention that about step types either. Will fix.

@ndw ndw merged commit 80b7b4d into xproc:master Nov 18, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ndw ndw deleted the ndw:iss-868 branch Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.