Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p:unescape-markup #137

Closed
xml-project opened this issue Jun 16, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@xml-project
Copy link
Contributor

commented Jun 16, 2019

p:unescape-markup uses the concept of a document element, but as we switched to XDM a document-node now can have multiple element children.
If we want to keep p:unescape-mark the inverse of p:escape-markup, we have to do something about this.

@gimsieke commented on this:

Can we keep the sentence “When the string value is parsed, the original document element is preserved so that the result will be well-formed XML even if the content consists of multiple, sibling elements.” if there can be multiple top-level elements?

@xml-project

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2019

@gimsieke said:

I propose that we delete the paragraph “When the string value is parsed […] multiple, sibling elements.” since we abandoned the concept of a single “document element” and because the result, when serialized, will not be well-formed if the input already contained multiple top-level elements.

@xml-project

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

The specs say on "p:unescape-markup": No document properties are preserved.

(1) I find it difficult to understand why: One might understand this as a special kind of "p:insert" and p:insert preserves all document properties.

(2) p:unescape-markup is explained as inverse to p:escape-markup: As the latter preserves document properties I would expect this for the former.

Is this an oversight or is there some reason I failed to see?

@eriksiegel

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

This might be just a mistake... Your reasoning certainly points in that direction. I have no objections.

@ndw

This comment has been minimized.

Copy link
Collaborator

commented Jun 20, 2019

Consensus on 20 June, it is an error if the input document has multiple top-level elements. As a general rule, steps that depend on the top level element should raise an error if there are multiple top-level elements.

@xml-project xml-project self-assigned this Jun 22, 2019

This was referenced Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.