Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are we sure about p:store? #162

Closed
ndw opened this issue Jul 14, 2019 · 2 comments

Comments

@ndw
Copy link
Collaborator

commented Jul 14, 2019

Since p:store never had a primary output port, any connection to it must be explicit. Changing what appears on the result port seems like it could be a source of frustration for users.

How about instead we leave result alone and add a new port original that is the primary output port and returns the original document. (I'm not super enthusiastic about the name "original", if anyone has a better idea...)

@xml-project

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

As you might remember, I was not a big fan of this approach. But I was convinced. Changing existing pipe connection for a 1.0 pipeline once is much better then swearing for years why the primary output port of p:store is not called "result".

@ndw

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 15, 2019

I guess that rings a vague bell. Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.