Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include and exclude filter are mislabeled on p:directory-list #166

Closed
ndw opened this issue Jul 18, 2019 · 2 comments

Comments

@ndw
Copy link
Collaborator

commented Jul 18, 2019

The comment says <!-- RegularExpression -->. It should be "List of RegularExpression" or "RegularExpressions" or, perhaps, removed entirely.

@ndw ndw added the editorial label Jul 18, 2019

@ndw ndw changed the title Include and exclude filter are mislabeled Include and exclude filter are mislabeled on p:directory-list Jul 18, 2019

@xml-project

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

👍
Since it is xs:string* you are right: The comment is wrong and needs to be changed. I would tend do opt for "List of Regular Expressions" and not "RegularExpression". This is because the list can be empty.
Do we need the comment after all? I think the prose has to cover this.

@ndw

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 18, 2019

I think we can just delete it.

@ndw ndw self-assigned this Jul 25, 2019

ndw added a commit to ndw/steps that referenced this issue Jul 25, 2019

@ndw ndw closed this in #175 Jul 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.