Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should/Does p:store with "file://" also create folders? #217

Closed
xml-project opened this issue Sep 20, 2019 · 5 comments · Fixed by #219

Comments

@xml-project
Copy link
Contributor

commented Sep 20, 2019

From a private conversion:

In p:store we just say that it is an error, if the resource can not be stored (which is obvious), but we do not say, what the step should undertake to make storing possible.

At least for "file:///" the question might come up, whether a processor will create all the folder necessary for storing the resource with the given URI.

I do not argue, a processor should do this, but I argue that we should say what a processor is expected to do or not to do.

@xml-project xml-project self-assigned this Sep 20, 2019
@ndw

This comment has been minimized.

Copy link
Collaborator

commented Sep 20, 2019

I agree that the most important thing is to document the behavior.

Does the JVM create them for you by default? I think it might but I could be wrong.

@xml-project

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2019

Does the JVM create them for you by default? I think it might but I could be wrong.

Nope! I think there is a switch in the JAVA API, but it is off by default.

What behaviour would you prefer:

  1. Creating folders
  2. Raising an error?
@ndw

This comment has been minimized.

Copy link
Collaborator

commented Sep 20, 2019

I believe that Saxon creates folders by default, so if there's no compelling reason to be different...I'd do that.

@xml-project

This comment has been minimized.

Copy link
Contributor Author

commented Sep 20, 2019

I believe that Saxon creates folders by default ....

Do you mean Saxon's command line behaviour?

@xml-project

This comment has been minimized.

Copy link
Contributor Author

commented Sep 21, 2019

@ndw You are right on XSLT: xsl:result-document href="create/some/folder/doc.xml" creates the required folders, so the document can be stored.
I think we should adapt this behaviour for file:// on p:store.
Will try to come up with a proposal.

xml-project added a commit that referenced this issue Sep 21, 2019
Attempt to fix issue #217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.