Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operative definition of error in p:uncompress needed #229

Open
xml-project opened this issue Oct 1, 2019 · 4 comments

Comments

@xml-project
Copy link
Contributor

commented Oct 1, 2019

In p:uncompress we have two errors:

  • It is a dynamic error (err:XC0200) if the compression format does not match the format as specified in the format option.

  • It is a dynamic error (err:XC0202) if the compression format cannot be understood, determined and/or processed.

While implementing it is unclear, under which conditions a processor should raise XC0200.

@ndw

This comment has been minimized.

Copy link
Collaborator

commented Oct 3, 2019

Indeed. I suppose you could raise XC0200 if the format was ZIP and the file format was TAR. But the likelihood is that you'd attempt to unzip it and get an error, raising XC0202.

I'm fine with abandoning XC0200.

@eriksiegel

This comment has been minimized.

Copy link
Contributor

commented Oct 15, 2019

Fine with me, I'll remove XC0200

@xml-project

This comment has been minimized.

Copy link
Contributor Author

commented Oct 15, 2019

Thank Erik. I can resolve this issue too. I just was not sure whether you had a special error case in mind which I missed.

@eriksiegel

This comment has been minimized.

Copy link
Contributor

commented Oct 16, 2019

@xml-project No I did not had a special case in mind, just didn't realize the implications. I don't know when I'll come around to doing this, so if this small thingy is in your way when implementing Morgana, please go ahead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.