Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content type of port result on p:text-join #319

Closed
xml-project opened this issue Jan 2, 2020 · 3 comments · Fixed by #320
Closed

Content type of port result on p:text-join #319

xml-project opened this issue Jan 2, 2020 · 3 comments · Fixed by #320
Assignees

Comments

@xml-project
Copy link
Contributor

@xml-project xml-project commented Jan 2, 2020

With pr #318 the content-types of p:text-join was changed from "text" to "text/plain". I think that was wrong.
There is an attribute "overwrite-content-type" which allows to set the content-type of the result (as long as it is a text content-type). So the correct value for output port "result" IMHO is "text".

@gimsieke

This comment has been minimized.

Copy link
Contributor

@gimsieke gimsieke commented Jan 2, 2020

I stumbled over this, too. I thought Norm’s reasoning to use text/plain was: By default it needs to be text/plain no matter what went into it, since the step cannot make sure that what comes out is still text/csv or whatever came in.

However, content-types does not describe the default content type of the result, but all possible content types. And this needs to be text. So I agree with you, Achim.

In addition, at one spot in the prose there is overwrite-content-type. It needs to be override-content-type.

@xml-project

This comment has been minimized.

Copy link
Contributor Author

@xml-project xml-project commented Jan 2, 2020

However, content-types does not describe the default content type of the result, but all possible content types.

Right: "XD0042" would be raised for @override-content-type other than "text/plain". This would make this option pretty useless.

@xml-project xml-project self-assigned this Jan 2, 2020
@ndw

This comment has been minimized.

Copy link
Collaborator

@ndw ndw commented Jan 2, 2020

Sorry. What happened was, I made a pass through where I over-enthusiastically changed the content-types of p:output from specific media types to shortcuts. I then thought better of that and attempted to undo that mess. In the case of p:text-join I was overzealous. It should be "text".

xml-project added a commit that referenced this issue Jan 2, 2020
Close #319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.