Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p:http-request is underspecified with respect to document properties as headers #369

Closed
ndw opened this issue Mar 18, 2020 · 4 comments
Closed
Assignees

Comments

@ndw
Copy link
Collaborator

@ndw ndw commented Mar 18, 2020

The spec says:

If a single document appears on the source port, then document properties on that document may be added as additional headers. All of the document properties will be used as headers except “base-uri”, “serialization” and any property...

I think we should say that only document properties in no-namespace are added. Otherwise, what do you do with a document property named ex:foo. You can't use "ex:foo" as a name. Even if { and } are allowed in header names (which I doubt), you can't use the Q{} syntax because the URI is almost always going to contain a colon.

We could say that you use the local name, but then you will always have errors if there are different properties with the same local name.

@ndw

This comment has been minimized.

Copy link
Collaborator Author

@ndw ndw commented Mar 18, 2020

I wonder, actually, if we should say that only headers in a particular namespace should be copied over. Today we have the situation that implementations are free to add additional properties. So it's difficult for users to predict what properties will exist.

(I just discovered this because I provide additional http properties as document properties, but that means if you copy them blindly across, you can wind up with weird http issues.)

@ndw

This comment has been minimized.

Copy link
Collaborator Author

@ndw ndw commented Mar 18, 2020

Or maybe I should put those extra properties in a namespace?

@Conal-Tuohy

This comment has been minimized.

Copy link

@Conal-Tuohy Conal-Tuohy commented Mar 18, 2020

I agree that not all document properties should be turned into headers. An XML namespace for HTTP headers seems on the face of it a good idea to me

@ndw

This comment has been minimized.

Copy link
Collaborator Author

@ndw ndw commented Mar 18, 2020

General agreement at the editor's call on 18 March that we'll say that properties in [namespace to be determined] will be copied as headers using the local-name as the header.

@ndw ndw self-assigned this Mar 18, 2020
ndw added a commit to ndw/steps that referenced this issue Mar 18, 2020
@ndw ndw closed this in #370 Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants
You can’t perform that action at this time.