Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move p:directory list? #54

Open
eriksiegel opened this issue Mar 21, 2019 · 5 comments

Comments

Projects
None yet
3 participants
@eriksiegel
Copy link
Contributor

commented Mar 21, 2019

Shouldn't p:directory-list be moved to the file steps?
The reason the file steps are optional (not everything has a file system) also applies to p:directory-list.

@xml-project

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

+1

@ndw ndw assigned ndw and xml-project and unassigned ndw Apr 23, 2019

@ndw

This comment has been minimized.

Copy link
Collaborator

commented Apr 23, 2019

Achim, you've got another issue to edit one of the directory-list steps. If I move them while you're editing them, we'll just get a nasty merge conflict. Can you move them when you're making your other changes?

@xml-project

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

OK, I see the problem.

Have we finally decided to move p:directory-list (and p:load-directory-list)? Missed that.

Can you move them when you're making your other changes?

What changes do I have to make on p:directory-list? Though I am done.

@ndw

This comment has been minimized.

Copy link
Collaborator

commented Apr 23, 2019

I thought we had consensus on that, but if you disagree...

Anyway #59 is still open and assigned to you, so I assumed you were working on something.

@xml-project

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

Nope, I agree - just lost the consensus.

Anyway #59 is still open and assigned to you, so I assumed you were working on something.

OK, I thought you referred to required changes on p:directory-list which I left out.

Will move both steps to the file-steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.