Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix 205 #209

Merged
merged 3 commits into from Sep 6, 2019

Conversation

@xml-project
Copy link
Contributor

commented Sep 5, 2019

Trying to fix #205

@gimsieke
Copy link
Contributor

left a comment

some typographic comments though…


<para><error code="C0101">It is a <glossterm>dynamic error</glossterm> if XQuery version
<literal>1.0</literal> is used and a document appearing on <port>source</port> port is not an XML document,
an HTML document, or a Text document.</error> <error code="C0102">It is a <glossterm>dynamic error</glossterm>

This comment has been minimized.

Copy link
@gimsieke

gimsieke Sep 5, 2019

Contributor

text document (lower case)

examining the version of the query.<impl>It is <glossterm>implementation defined</glossterm>
which XQuery version(s) is/are supported.</impl></para>

<para>The name/value pairs in option <option>parameters</option> are used to set the query's

This comment has been minimized.

Copy link
@gimsieke

gimsieke Sep 5, 2019

Contributor

query’s (U+2019 apostrophe)

an array, or a function.</error></para>

<para><error code="C0103">It is a <glossterm>dynamic error</glossterm> if any error occurs during
XQuery's static analysis phase.</error> <error code="C0104">It is a <glossterm>dynamic error</glossterm>

This comment has been minimized.

Copy link
@gimsieke

gimsieke Sep 5, 2019

Contributor

XQuery’s (U+2019)

@xml-project

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

Got it wrong, sorry. A binary document error isn't an error in 1.0 and 3.0, but a JSON document is an error in 3.0, not in 3.1.

@xml-project

This comment has been minimized.

Copy link
Contributor Author

commented Sep 5, 2019

I think I got it right now because some variants of JSON document (strings, numbers) can be represented in XDM 2.0 The wording is now more abstract, but I think this should work.

@xml-project xml-project requested a review from gimsieke Sep 5, 2019


<para><error code="C0101">It is a <glossterm>dynamic error</glossterm> if a document
appearing on port <port>source</port> cannot be represented in the XDM version associated with
the chosen XQuery version, e.g. when a JSON document contains a map and XDM 2.0 is used.</error>

This comment has been minimized.

Copy link
@gimsieke

gimsieke Sep 6, 2019

Contributor

Do we cite examples for failure causes in other error messages, too? I think it can be helpful, but it can also be misleading. Since it is marked as an example for an error cause, users shouldn’t be misled though. Generally, do we give examples in error messages? Nothing against it personally, but maybe @ndw or @eriksiegel have an opinion on this.
Otherwise approve.

This comment has been minimized.

Copy link
@ndw

ndw Sep 6, 2019

Collaborator

I don't think we have a consistent policy on it. As long as causes are clearly "for examples", I think it's ok.

@xml-project

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

@eriksiegel @ndw Any comment?

@ndw
ndw approved these changes Sep 6, 2019

@xml-project xml-project merged commit 72734e3 into xproc:master Sep 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xml-project xml-project deleted the xml-project:fix-205 branch Sep 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.