Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the specification of p:markdown-to-html #311

Merged
merged 1 commit into from Jan 1, 2020
Merged

Conversation

@ndw
Copy link
Collaborator

ndw commented Jan 1, 2020

Fix #39

I think this counts as a fix. We've moved the other text steps into the core step library, so this one can be for the markdown step. We might find more text-like steps to add later

@ndw ndw requested a review from xproc/spec-authors Jan 1, 2020
Copy link
Contributor

xml-project left a comment

I aprove the changes you made, but I do not understand your comment on the PR:

We've moved the other text steps into the core step library, so this one can be for the markdown step. We might find more text-like steps to add later

Does that mean you propose to get rid of a text related library for now? If so, I do not agree with it.
To my memory we allready spoke about other (non-standard) text related steps. But may be I am wrong about this. Steps I have in mind are certainly related to CSV, e.g. CSV->XML and CSV->JSON.
And: "p:discover-xml" (aka "p:pemberton") would IMHO be primarly a text related step, wouldn't it?

@ndw

This comment has been minimized.

Copy link
Collaborator Author

ndw commented Jan 1, 2020

No, no, nothing like that. At the June workshop, we still had the text steps in this spec (I think) and the comment on p:markdown says "create a library for optional steps; or create a step library for this step."

All I meant in my comment above was that I think this document qualifies as a step library for this step.

@ndw ndw merged commit d4b3cc0 into xproc:master Jan 1, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ndw ndw deleted the ndw:iss-39 branch Jan 1, 2020
@xml-project

This comment has been minimized.

Copy link
Contributor

xml-project commented Jan 1, 2020

@ndw 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.