Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of p:http-request #330

Merged
merged 3 commits into from Jan 7, 2020
Merged

Conversation

@xml-project
Copy link
Contributor

xml-project commented Jan 5, 2020

Please find here the first draft on p:http-request which is to replace the existing text comming from the 1.0 specs.
@ndw @xatapult @Gertone @gimsieke
"Edit from maintainers" is on, so feel free to make changes.

@xatapult

This comment has been minimized.

Copy link
Contributor

xatapult commented Jan 6, 2020

Is there a build where we can look at the formatted result somewhere?

And there are no reviewers mentioned. Intentional or oversight?

@xml-project

This comment has been minimized.

Copy link
Contributor Author

xml-project commented Jan 6, 2020

Is there a build where we can look at the formatted result somewhere?

Send you a mail this afternoon.

And there are no reviewers mentioned. Intentional or oversight?

As it is not finished, I did not want to ask for a review because I am not sure, we want to merge it in this state. Any opinion?

@xatapult

This comment has been minimized.

Copy link
Contributor

xatapult commented Jan 6, 2020

Probably the devil is in the details, but this looks very OK to me. It reflects (as far as I remember) what we spoke about in Cologne and later.

@ndw

This comment has been minimized.

Copy link
Collaborator

ndw commented Jan 6, 2020

I thought there were some changes proposed at our editor's call. I think it makes sense to make those changes and make another editorial pass.

@xml-project

This comment has been minimized.

Copy link
Contributor Author

xml-project commented Jan 6, 2020

@ndw I thought I did make the requested changes from editors call. What did I left out?

@xatapult

This comment has been minimized.

Copy link
Contributor

xatapult commented Jan 6, 2020

I took the liberty to change some words and grammar without changing meaning.

@xatapult

This comment has been minimized.

Copy link
Contributor

xatapult commented Jan 6, 2020

The description of the serialization option differs.

  • The introduction mentions that the serialization property is ignored when more than one document appears on the source port
  • Later on it says that the serialization property is used for all documents on the source port
@xatapult

This comment has been minimized.

Copy link
Contributor

xatapult commented Jan 6, 2020

Urgh. What did I do to make the build fail? Can't make sense of the Travis generated error message

@xml-project

This comment has been minimized.

Copy link
Contributor Author

xml-project commented Jan 6, 2020

@xatapult Oh, left that out.

@ndw

This comment has been minimized.

Copy link
Collaborator

ndw commented Jan 6, 2020

At a glance, @xatapult you've made steps/http-request.xml not well-formed XML or not valid DocBook.

@xml-project

This comment has been minimized.

Copy link
Contributor Author

xml-project commented Jan 6, 2020

Not sure what happend, but now I am out on my own PR. Trying to push something to my repo's branch git says, I had to merge Erik changes first. No idea what that means.
Let's see if it goes away once travis passes.

@xml-project

This comment has been minimized.

Copy link
Contributor Author

xml-project commented Jan 6, 2020

@xatapult

Urgh. What did I do to make the build fail? Can't make sense of the Travis generated error message

It is in line 131: a </error> close is missing. Sorry, can't fix it for you.

@xml-project xml-project requested review from gimsieke, ndw and xatapult Jan 7, 2020
@xatapult

This comment has been minimized.

Copy link
Contributor

xatapult commented Jan 7, 2020

Maybe we should limit the discussion(s) about http-request to a single issue. You now mention several. So I suggest to close all except one (or all and open a new one especially for finishing http-request)

@xml-project xml-project merged commit 3801ac5 into xproc:master Jan 7, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@xml-project xml-project deleted the xml-project:http-request branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.