Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #347 by reworking headers and parameters #348

Merged
merged 3 commits into from Jan 30, 2020
Merged

Fix #347 by reworking headers and parameters #348

merged 3 commits into from Jan 30, 2020

Conversation

@ndw
Copy link
Collaborator

ndw commented Jan 30, 2020

  1. Fix #335 by adding an error
  2. Fix #347 by clarifying headers and parameters per discussion on that issue.
  3. Settle on lowercase.
ndw added 3 commits Jan 30, 2020
@ndw ndw requested a review from xproc/spec-authors Jan 30, 2020
Copy link
Contributor

gimsieke left a comment

Looking good, but @xml-project needs to give his blessing, too

Copy link
Contributor

xml-project left a comment

Looks good to me.
But this is what I said the last time too. So lets see what happens if I try to implement this.

@ndw ndw merged commit cc3371b into xproc:master Jan 30, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ndw ndw deleted the ndw:http-headers branch Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.