Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use document properties as headers only if they're in the correct namespace #370

Merged
merged 3 commits into from Mar 19, 2020

Conversation

@ndw
Copy link
Collaborator

ndw commented Mar 18, 2020

Attempt to fix #369

I invented a new namespace; I wonder if using the step namespace would be better.

@ndw ndw requested review from xml-project, gimsieke, xproc/spec-authors and xatapult Mar 18, 2020
Copy link
Contributor

gimsieke left a comment

I have a slight preference for a dedicated namespace, as you introduced it.

Using the step namespace might clash with future document properties for which we then need to come up with another namespace. For example, a hypothetical c:trace document property that contains a structure with information about all preceding step invocations and the one that emitted the document.

<para>All of the document properties in the
<code>http://www.w3.org/ns/xproc-http</code> namespace will be added
as headers for the part, using the local-name of the property QName as
the header name. In particular, this is now the

This comment has been minimized.

Copy link
@gimsieke

gimsieke Mar 18, 2020

Contributor

this is how the …?

@ndw ndw merged commit 8912db6 into xproc:master Mar 19, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ndw ndw deleted the ndw:iss-369 branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.