Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test ab-hash-007.xml #191

Closed
ndw opened this issue Jun 30, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@ndw
Copy link
Contributor

commented Jun 30, 2019

Hi Achim,

I don't believe that ab-hash-007.xml should pass. After the step runs, doc/text() consists of 18 spaces followed by the hash, so doc/text()='852b1f51' is not true.

We can fix the test by changing the expression to compare against the normalized space version of the string, or remove the spaces from the input document, or probably any of several other ways.

I'm happy to send along a fix, if you have a preference.

@xml-project

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2019

I agree. I will file a fix for this test as soon as I know, why my implementation passes it.

@xml-project

This comment has been minimized.

Copy link
Contributor

commented Jun 30, 2019

Covered with PR #192

@xml-project

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Fixed with #192

@xml-project xml-project closed this Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.