New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about ab-p-document028.xml #46

Closed
ndw opened this Issue Oct 5, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@ndw
Contributor

ndw commented Oct 5, 2018

The expected content type is application/zip, but I'm not sure that's justified by the current spec.

There seem to be three rules:

  1. If a content-type property is specified in document-properties or content-type is present, then each document must be interpreted according to that content type. By that rule, its content type should be application/octet-stream.
  2. If the documents are retrieved with a URI protocol that specifies a content type (for example, http:), then the document must be interpreted according to that content type. This rule doesn't apply because file: is not a URI protocol that specifies a content type.
  3. In the absence of an explicit type, the content type is implementation-defined. This rule doesn't apply because the content type is specified.

So I think the result should be application/octet-stream. What am I missing?

@xml-project xml-project self-assigned this Oct 5, 2018

@xml-project

This comment has been minimized.

Show comment
Hide comment
@xml-project

xml-project Oct 5, 2018

Contributor

Yes, you are absolutely right. Some of the tests are older and do not reflect changes, we made to the specs. And some tests are obviously wrong.

I will split this test in two tests:
(1) application/octet-stream is preserved although the processor knows another content-type.
(2) application/zip is returned if no content-type is specified.

Contributor

xml-project commented Oct 5, 2018

Yes, you are absolutely right. Some of the tests are older and do not reflect changes, we made to the specs. And some tests are obviously wrong.

I will split this test in two tests:
(1) application/octet-stream is preserved although the processor knows another content-type.
(2) application/zip is returned if no content-type is specified.

xml-project added a commit that referenced this issue Oct 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment