New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple errors #51

Closed
ndw opened this Issue Oct 7, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@ndw
Contributor

ndw commented Oct 7, 2018

The current test suite allows a single error code, for example, ab-p-document015.xml:

<t:test xmlns:t='http://xproc.org/ns/testsuite/3.0'
        xmlns:err="http://www.w3.org/ns/xproc-error"
        expected="fail" code="err:XD0023">
    <t:title>p:document 015</t:title>
    ...

I'd like to change the schema so that multiple error codes are allowed. In particular, I get a file not found error for the missing dtd in this test. I think that's a perfectly reasonable response code, but I don't think "invalid" is unreasonable.
In general, it's hard to get completely identical errors across implementations. In the 1.0 test suite, we let any error succeed. I think we can try to do a little better here.

@xml-project

This comment has been minimized.

Show comment
Hide comment
@xml-project

xml-project Oct 7, 2018

Contributor

I agree.
What about changing "@code" to a whitespace separated list of error codes and say, that the test is successful, if at least one of the listed error codes is matched?

Contributor

xml-project commented Oct 7, 2018

I agree.
What about changing "@code" to a whitespace separated list of error codes and say, that the test is successful, if at least one of the listed error codes is matched?

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Oct 7, 2018

Contributor

Exactly what I had in mind. I'm working on it now.
I'm also adding some more metadata to the test-suite schema and I'll arrange it so that the test suite is validated on each PR.

Contributor

ndw commented Oct 7, 2018

Exactly what I had in mind. I'm working on it now.
I'm also adding some more metadata to the test-suite schema and I'll arrange it so that the test suite is validated on each PR.

@xml-project

This comment has been minimized.

Show comment
Hide comment
@xml-project

xml-project Oct 7, 2018

Contributor

👍

Contributor

xml-project commented Oct 7, 2018

👍

@xml-project

This comment has been minimized.

Show comment
Hide comment
@xml-project

xml-project Oct 8, 2018

Contributor

Solved with pr #52

Contributor

xml-project commented Oct 8, 2018

Solved with pr #52

@xml-project xml-project closed this Oct 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment