New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken tests #68

Closed
xml-project opened this Issue Oct 11, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@xml-project
Contributor

xml-project commented Oct 11, 2018

All tests with an additional namespace declaration on the outer p:declare-step are broken somehow by the conversion because the namespace is now moved to the element, where it is needed.
As a consequence it is no longer available on p:declare-step/type. E.g. ab-connection-008.xml.

Since these are only a few test (ca. 30) I will fix them by hand.

@xml-project xml-project self-assigned this Oct 11, 2018

@ndw

This comment has been minimized.

Contributor

ndw commented Oct 11, 2018

Awww, dang it. I tried to make sure the namespaces went in the right places. Sorry I missed those. And sorry about the confusion on revision history. I guess I changed my mind (so that t:info/t:revision[1] is always the newest) and didn't update the docs.

@xml-project

This comment has been minimized.

Contributor

xml-project commented Oct 11, 2018

Never mind. I think we made great progress with your revision and the different views on the test suite.
Will fix the broken tests tomorrow.

xml-project added a commit that referenced this issue Oct 12, 2018

@xml-project

This comment has been minimized.

Contributor

xml-project commented Oct 12, 2018

Fixed with pr #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment