New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More namespace issues #83

Closed
ndw opened this Issue Oct 14, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@ndw
Contributor

ndw commented Oct 14, 2018

I'm going to keep this one open for a bit in case I find more, but

  • ab-with-input-select-008.xml is broken because the default namespace is wrong in the pipeline

@ndw ndw self-assigned this Oct 14, 2018

@xml-project

This comment has been minimized.

Contributor

xml-project commented Oct 14, 2018

Since the revision "http://www.w3.org/1999/xhtml" is the default namespace and I haven't recovered from this yet.
I think we should change this either by removing the xmlns="http://www.w3.org/1999/xhtml" declaration from t:test and adding it to the XHTML-fragments in t:description.

@ndw

This comment has been minimized.

Contributor

ndw commented Oct 14, 2018

I've fixed it locally by adding xmlns="" to the p:pipeline
Or are you suggesting we should do a wholesale conversion and move the HTML namespaces to the t:description elements?

@xml-project

This comment has been minimized.

Contributor

xml-project commented Oct 14, 2018

Or are you suggesting we should do a wholesale conversion and move the HTML namespaces to the t:description elements?

I think this is the better solution. The two of us might remember the problem, but if we invite other people to write tests (and I strongly do!), this may be a trap.

@ndw

This comment has been minimized.

Contributor

ndw commented Oct 14, 2018

Ok. I'll make a pass over all the files. I'll make that change and see about finding any other errors.

@xml-project

This comment has been minimized.

Contributor

xml-project commented Oct 14, 2018

Great. There are six more test in a RP. Should I fix them by hand or should we merge them first?

@ndw

This comment has been minimized.

Contributor

ndw commented Oct 14, 2018

Merge 'em in and I'll do the namespace fix up next (instead of trying to track down my try/catch/finally bug 😄 )

@xml-project

This comment has been minimized.

Contributor

xml-project commented Oct 14, 2018

Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment