Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed test nw-collection-003 #150

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@xml-project
Copy link
Contributor

xml-project commented Apr 2, 2019

Changed test nw-collection-003 in order to fix #100
@ndw could you please check (and approve) this change.

@xml-project xml-project requested a review from ndw Apr 2, 2019

@ndw

This comment has been minimized.

Copy link
Contributor

ndw commented Apr 3, 2019

I agree that (on inspection) it passes with your changes, but I think it would be better to fix the test so that it fails. It was supposed to demonstrate that it's an error to refer to the context item if there's a sequence of nodes.

@xml-project

This comment has been minimized.

Copy link
Contributor Author

xml-project commented Apr 4, 2019

Good point, I will change the test, so the pipeline will fail for the given reason.

@xml-project xml-project closed this Apr 4, 2019

@xml-project xml-project deleted the xml-project:fix-test branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.