Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial p:viewport tests #198

Merged
merged 1 commit into from Jul 9, 2019

Conversation

Projects
None yet
2 participants
@ndw
Copy link
Contributor

commented Jul 8, 2019

"Simple matter of programming."

@ndw ndw requested a review from xml-project Jul 8, 2019

@xml-project
Copy link
Contributor

left a comment

I think we should merge our new tests without waiting for approval. If we find our processors to deliver different results, we could discuss it then.
I thing an approval is only necessary if one changes an existing test to produce a different result. To know this before will be helpful to see, why our processors suddenly reports different results.

@ndw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

Okay by me.

@ndw ndw merged commit 83f0bf1 into xproc:master Jul 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ndw ndw deleted the ndw:viewport branch Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.