Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for two of the try/catch DRP tests #229

Merged
merged 7 commits into from Jul 23, 2019

Conversation

@ndw
Copy link
Contributor

commented Jul 22, 2019

Hi @xml-project

Here are fixes for two of the tests. I apparently don't pass the other two :-( so I haven't been able to test them.

Feel free to take these or ignore them, as you see fit.

@ndw ndw requested a review from xml-project Jul 22, 2019

ndw added some commits Jul 22, 2019

Merge pull request #230 from ndw/refactor-build
Attempt to fix memory issues
@xml-project
Copy link
Contributor

left a comment

Both tests look good to me, but Travis fails with a validation error. I guess that might be because you put the revision date to "2018-07-22" although we have 2019.

@ndw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2019

I fixed the dates. Merging now.

@ndw ndw merged commit 065619c into xproc:master Jul 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ndw ndw deleted the ndw:iss-228-in-part branch Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.