Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove two tests overtaken by events #233

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@xml-project
Copy link
Contributor

commented Jul 23, 2019

Attempt to fix #228
I removed the two tests because they do not make sense anymore.

@xml-project xml-project requested a review from ndw Jul 23, 2019

@ndw

This comment has been minimized.

Copy link
Contributor

commented Jul 23, 2019

This situation is more complicated than it appears at first. The semantics of p:error are that it's input becomes the error document. So, in fact, these tests work they way they were originally written, but for a completely different reason.

In fact, now that I've fixed p:error, my changes to 004 and 023 have made them fail.

I'll post another PR for 004 and 023.

@ndw

ndw approved these changes Jul 23, 2019

@xml-project xml-project merged commit a907652 into xproc:master Jul 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@xml-project xml-project deleted the xml-project:fix-tests branch Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.