Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed changes to unwrap tests #242

Merged
merged 2 commits into from Jul 25, 2019

Conversation

@ndw
Copy link
Contributor

commented Jul 24, 2019

Some of the unwrap tests seem to assume that whitespace is being removed from the test inputs. I don't think that's the expected behavior. Here are a couple of proposed fixes.

Or am I mistaken about something?

@ndw ndw requested a review from xml-project Jul 24, 2019

@ndw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

Conversely, I think ab-escape-markup-004.xml is wrong because we say that p:inline does strip leading and trailing whitespace.

@ndw ndw merged commit 3bcd181 into xproc:master Jul 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ndw ndw deleted the ndw:unwrap branch Jul 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.