Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests for exact numbers of properties #249

Merged
merged 1 commit into from Jul 26, 2019

Conversation

@ndw
Copy link
Contributor

commented Jul 26, 2019

I think these tests are overly-constraining. My implementation adds additional properties (e.g., content-length) for binary documents. I don't think that's non-conformant.

@ndw ndw requested a review from xml-project Jul 26, 2019

@ndw

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

I suppose testing for "at least" that many properties would be ok, but I think there are already explicit tests for the precise properties expected, so that doesn't seem like it would add value.

@xml-project
Copy link
Contributor

left a comment

Yes, it's stupid to restrict the number of document-properties. Sorry.

@ndw ndw merged commit 0503235 into xproc:master Jul 26, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ndw ndw deleted the ndw:set-prop branch Jul 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.