Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed changes for json-merge tests #340

Merged
merged 2 commits into from Dec 15, 2019
Merged

Proposed changes for json-merge tests #340

merged 2 commits into from Dec 15, 2019

Conversation

@ndw
Copy link
Contributor

ndw commented Dec 14, 2019

The first patch fixes #338

In tests 18 and 19, the test checks for an "html" element in no-namespace after parsing as text/html. I don't believe that is possible. I believe our HTML5 story is that we always produce html elements in the (X)HTML namespace.

@ndw ndw requested a review from xml-project Dec 14, 2019
Copy link
Contributor

xml-project left a comment

I agree with the first change, but are not sure about the last two. You say:

I don't believe that is possible. I believe our HTML5 story is that we always produce html elements in the (X)HTML namespace.

But I can't find this in the specs. On p:load we say:

The precise way in which HTML documents are parsed into the XPath data model is implementation-defined.

To my reading that means, my result is possible as well as yours. What did I miss?

@ndw

This comment has been minimized.

Copy link
Contributor Author

ndw commented Dec 15, 2019

Nothing, I guess. I forgot it was that vague. I removed the namespace declaration from the -18 test. Now it accepts *:html and the -19 test already accepts <html with or without a namespace, so I think all three tests should now pass for both implementations.

Good enough?

@xml-project

This comment has been minimized.

Copy link
Contributor

xml-project commented Dec 15, 2019

Thanks @ndw.

@xml-project xml-project self-requested a review Dec 15, 2019
@ndw ndw merged commit 63d68d6 into xproc:master Dec 15, 2019
@ndw ndw deleted the ndw:merge-fixes branch Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.