New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content type test #40

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@ndw
Contributor

ndw commented Oct 4, 2018

I think this fixes the test.

@ndw ndw requested a review from xml-project Oct 4, 2018

@xml-project

This comment has been minimized.

Show comment
Hide comment
@xml-project

xml-project Oct 4, 2018

Contributor

What is wrong with my revision of the test in pr #39 ?

Contributor

xml-project commented Oct 4, 2018

What is wrong with my revision of the test in pr #39 ?

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Oct 4, 2018

Contributor

Nothing except for the fact that I apparently looked right past it yesterday. 😦
However, you've changed both tests so that they pass, I think it would be good to keep one that fails. I'll delete my PR; can you add an example of a failing test to this PR?

Contributor

ndw commented Oct 4, 2018

Nothing except for the fact that I apparently looked right past it yesterday. 😦
However, you've changed both tests so that they pass, I think it would be good to keep one that fails. I'll delete my PR; can you add an example of a failing test to this PR?

@xml-project

You can delete this. I added your test as ab-content-types-010.xml. Will be part of my next pr.

@ndw

This comment has been minimized.

Show comment
Hide comment
@ndw

ndw Oct 4, 2018

Contributor

Thanks, @xml-project !

Contributor

ndw commented Oct 4, 2018

Thanks, @xml-project !

@ndw ndw closed this Oct 4, 2018

@ndw ndw deleted the ndw:fix-ct-003 branch Oct 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment