New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported err:XS0001 tests from the 1.0 test suite #96

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
2 participants
@ndw
Contributor

ndw commented Oct 16, 2018

We should look generally at porting the 1.0 test suite, I guess.

@ndw ndw requested a review from xml-project Oct 16, 2018

@xml-project

This comment has been minimized.

Contributor

xml-project commented Oct 16, 2018

By the way: I think we should change the text of XS0001 so that it is not only reserved for loops between steps, but also covers loops between steps and variable, and variables and variables.
Loop is loop, so I do not see any special importance in introducing new error codes for the new kinds of loops. The rest is IMHO quality of implementation.
Will file an issue for that tomorrow.

@ndw

This comment has been minimized.

Contributor

ndw commented Oct 16, 2018

👍

@ndw ndw merged commit 4aed7b5 into xproc:master Oct 16, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ndw ndw deleted the ndw:xs0001 branch Oct 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment