Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'drop' in 'coords' doesn't drop over 'ret' direction #43

Closed
xrobin opened this issue Mar 12, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@xrobin
Copy link
Owner

commented Mar 12, 2019

coords(r.s100b, c(0.51, 0.2), input = "threshold", ret = "specificity", drop = TRUE)
coords(r.s100b, "local maximas", input = "threshold", ret = "specificity", drop = TRUE)

Both return a matrix with 1 row. Note: this is tested in test-coords.R but the test is skipped as it fails.

The documentation only mentions dropping over length(x), but also doesn't state that it won't drop if length(ret) == 1. The doc should be either updated to mention not dropping over ret, or updated to mention to drop over ret and the code updated accordingly.

This however is an api change and too close for 1.14.

xrobin added a commit that referenced this issue Mar 12, 2019

@xrobin xrobin closed this May 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.