Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forthcoming release of ggplot2 and pROC #53

Closed
paleolimbot opened this issue May 14, 2019 · 3 comments

Comments

@paleolimbot
Copy link

commented May 14, 2019

We are contacting you because you are the maintainer of pROC, which imports ggplot2 and uses vdiffr to manage visual test cases. The upcoming release of ggplot2 includes several improvements to plot rendering, including the ability to specify lineend and linejoin in geom_rect() and geom_tile(), and improved rendering of text. These improvements will result in subtle changes to your vdiffr dopplegangers when the new version is released.

Because vdiffr test cases do not run on CRAN by default, your CRAN checks will still pass. However, we suggest updating your visual test cases with the new version of ggplot2 as soon as possible to avoid confusion. You can install the development version of ggplot2 using remotes::install_github("tidyverse/ggplot2").

If you have any questions, let me know!

@paleolimbot

This comment has been minimized.

Copy link
Author

commented May 15, 2019

We're hoping to release it in the next week or two! We don't know the exact timing because the submission to CRAN takes time and may result in more changes.

@xrobin

This comment has been minimized.

Copy link
Owner

commented May 17, 2019

I ran vdiffr::manage_cases() with ggplot 3.1.1.9000 and vdiffr found no difference. I will keep an eye open in the next few weeks if any test starts to fail. Thanks!

@xrobin xrobin closed this May 17, 2019

xrobin added a commit that referenced this issue Jun 18, 2019

@xrobin

This comment has been minimized.

Copy link
Owner

commented Jun 18, 2019

CI failed as ggplot2 was updated now. It's a good positive test to ensure the tests are run. Fixed now and merged into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.