-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transpose coords #54
Comments
See wiki page Updating coords for an assessment of potential impact on dependent packages. |
|
4 emails and 2 PR sent to authors of packages found using |
Use tidy version of coords (xrobin/pROC#54)
Use tidy version of coords (xrobin/pROC#54)
Email sent now to 57 reverse depends/imports (5 delivery failures) and 21 reverse suggests (1 delivery failure). Reminder diff sent to Colin Tredoux (r4lineups) and bug report for biomod2 (bug #6650), which are the last 2 packages detected as impacted that haven't been fixed yet. |
Needed to drop row names which are not allowed to be duplicated. Update doc with latest changes.
Needed to drop row names which are not allowed to be duplicated. Update doc with latest changes. Turn off dropping dimensions by default.
The coords function now uses a data.frame internally too. Following Tibble's Overview, I dropped row names which are sometimes duplicated, and turned off dropping dimensions by default. This required some adaptation of the tests and examples. |
The use of a data.frame internally came with a significant performance hit (apparently related to row indexing/updating operations, which are used a lot here). CI operations became unacceptably slow. Reverted to use matrix internally and added an as.matrix option, used in CI. Still defaults to returning a data.frame, but conversion happens in the end. |
pROC 1.16.0 is on CRAN with transpose = FALSE by default. Closing, future changes to remove the warning (probably in ~ 1 year) and potentially drop transpose = TRUE altogether will go to new issues. |
Coords returns a matrix with thresholds in columns, and the measurement in rows.
This has always been a bit weird but is becoming problematic with pipelines where a data.frame in transposed form would be better suited.
Expected behavior
The text was updated successfully, but these errors were encountered: