Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transpose coords #54

Open
xrobin opened this issue May 19, 2019 · 4 comments

Comments

Projects
None yet
1 participant
@xrobin
Copy link
Owner

commented May 19, 2019

Coords returns a matrix with thresholds in columns, and the measurement in rows.

This has always been a bit weird but is becoming problematic with pipelines where a data.frame in transposed form would be better suited.

Expected behavior

> library(dplyr)
> roc(aSAH, outcome, wfns) %>% coords()
Setting levels: control = Good, case = Poor
Setting direction: controls < cases
                threshold specificity sensitivity
      -Inf   0.0000000   1.0000000
       1.5   0.5138889   0.9512195
       2.5   0.7916667   0.6585366
       3.5   0.8333333   0.6341463
       4.5   0.9444444   0.4390244
       Inf   1.0000000   0.0000000

@xrobin xrobin added the api-change label May 19, 2019

xrobin added a commit that referenced this issue May 19, 2019

xrobin added a commit that referenced this issue May 19, 2019

xrobin added a commit that referenced this issue May 19, 2019

@xrobin

This comment has been minimized.

Copy link
Owner Author

commented May 21, 2019

See wiki page Updating coords for an assessment of potential impact on dependent packages.

xrobin added a commit that referenced this issue May 23, 2019

@xrobin

This comment has been minimized.

Copy link
Owner Author

commented May 23, 2019

  • TODO: add an FAQ entry documenting this change, the warning, and how to silence it.

xrobin added a commit that referenced this issue May 23, 2019

xrobin added a commit that referenced this issue May 23, 2019

xrobin added a commit that referenced this issue May 24, 2019

xrobin added a commit that referenced this issue May 24, 2019

xrobin added a commit that referenced this issue May 31, 2019

xrobin added a commit that referenced this issue May 31, 2019

xrobin added a commit that referenced this issue May 31, 2019

xrobin added a commit to xrobin/yardstick that referenced this issue May 31, 2019

@xrobin

This comment has been minimized.

Copy link
Owner Author

commented Jun 1, 2019

Email sent to 49 maintainers of reverse dependencies.

Delivery failures for EFS (Ursula Neumann, mailbox quota exceeded), blkbox (Boris Guennewig, 550 Address rejected), and sambia (Norbert Krautenbacher, 550 Recipient address rejected).

@xrobin

This comment has been minimized.

Copy link
Owner Author

commented Jun 10, 2019

4 emails and 2 PR sent to authors of packages found using coords:

lwaldron added a commit to lwaldron/doppelgangR that referenced this issue Jun 10, 2019

Merge pull request #19 from xrobin/master
Use tidy version of coords (xrobin/pROC#54)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.