-
Notifications
You must be signed in to change notification settings - Fork 31
Bootstrap test for two correlated curves #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for your report. Can you please provide the data you used to generate these ROC curves as requested in the bug report template? |
roc1<-roc(Data_1$class, Data_1$V1) |
Data associated with the issue |
This is very useful, thank you. Here is a code snippet to fully reproduce:
Although there is no guarantee that the two tests should return the same value, this seems definitely more different that I would expect, and I can't see an obvious reason why the values would be reversed. See:
I will investigate this in more detail as soon as I can. |
I finally had time to look at the issue. It turns out the reason is that the curves have direction=">". This is clearly not handled properly by the delong test in pROC and needs to be fixed. |
This issue is now fixed in the development version of pROC, and the delong test returns the correct result for these ROC curves:
Please let me know if you think this doesn't solve your problem. Thanks again for your report and for helping me make pROC better! |
When testing Delong versus bootstrap using alternative "less", I obtained quite different results for p-values. It seems to be an error in bootstrap (?) (1-p-value ?)
data: roc1 and roc2
Z = -1.9582, p-value = 0.0251
alternative hypothesis: true difference in AUC is less than 0
sample estimates:
AUC of roc1 AUC of roc2
0.7388633 0.5391705
data: roc1 and roc2
D = 1.971, boot.n = 2000, boot.stratified = 1, p-value = 0.9756
alternative hypothesis: true difference in AUC is less than 0
sample estimates:
AUC of roc1 AUC of roc2
0.7388633 0.5391705
The text was updated successfully, but these errors were encountered: