From f81ac5040da3b2deede074d98fd4b11418cabc24 Mon Sep 17 00:00:00 2001 From: Brian Bockelman Date: Tue, 26 Mar 2019 08:30:02 -0500 Subject: [PATCH] Fixup fallthrough statements. Apparently GCC only can handle the `fallthrough` comment (and skip a warning) if it is the last statement before the next case. Fixes build failures on GCC7+ platforms such as Fedora and latest Debian. --- src/XrdHttp/XrdHttpReq.cc | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/XrdHttp/XrdHttpReq.cc b/src/XrdHttp/XrdHttpReq.cc index 3aafc29de3d..a3b3df141b6 100644 --- a/src/XrdHttp/XrdHttpReq.cc +++ b/src/XrdHttp/XrdHttpReq.cc @@ -1191,8 +1191,8 @@ int XrdHttpReq::ProcessHTTPReq() { // We want to be invoked again after this request is finished return 0; } - // fallthrough } + // fallthrough default: // Read() or Close() { @@ -2159,9 +2159,9 @@ int XrdHttpReq::PostProcessHTTPReq(bool final_) { return -1; } - // Remaining case: reqstate == 2 and we didn't ask for a digest (should be a read); - // fallthrough + // Remaining case: reqstate == 2 and we didn't ask for a digest (should be a read). } + // fallthrough default: //read or readv {