Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script misses firewall & setsebool #26

Closed
cointrek opened this issue Aug 5, 2018 · 3 comments
Closed

Script misses firewall & setsebool #26

cointrek opened this issue Aug 5, 2018 · 3 comments

Comments

@cointrek
Copy link

cointrek commented Aug 5, 2018

Describe the issues
Add

To Reproduce
You can run the script to completion and note that the commands have not been executed.

Expected behavior
Add:
setsebool -P httpd_can_network_connect 1
yum install firewalld
systemctl start firewalld
firewall-cmd --zone=public --add-port=443/tcp --permanent
firewall-cmd --zone=public --add-port=7768/tcp --permanent
firewall-cmd --reload

Screenshots
N/A

@jmannanc
Copy link
Contributor

jmannanc commented Aug 5, 2018

The script does those things except it doesn't install firewalld, just runs the firewall-cmd --zone=public --add-port=443/tcp --permanent in case firewalld is installed. As for firewall-cmd --zone=public --add-port=7768/tcp --permanent, I recommend you don't do this as that's opening up your moneyd account port to the public. You should be fine without it.

@jmannanc
Copy link
Contributor

jmannanc commented Aug 5, 2018

Actually you're right, there is one thing that is missing. firewall-cmd --reload is missing, my bad. I will open a PR to address this.

@cointrek
Copy link
Author

cointrek commented Aug 5, 2018

Sweet! Happy to contribute. And, thanks.

@N3TC4T N3TC4T closed this as completed in #27 Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants