Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn peer [add|ls|remove] commands don't return shell #6

Closed
pkcs8 opened this issue Aug 9, 2022 · 0 comments · Fixed by #26
Closed

yarn peer [add|ls|remove] commands don't return shell #6

pkcs8 opened this issue Aug 9, 2022 · 0 comments · Fixed by #26

Comments

@pkcs8
Copy link
Member

pkcs8 commented Aug 9, 2022 •
edited
Loading

npm run peer [add|ls|remove] or yarn peer [add|ls|remove] don't return control back to the shell. This is probably happening because database connection is still active. Fix database connection logic so the connection can be closed when needed.
@pkcs8 pkcs8 changed the title yarn peer * commands don't return shell yarn peer [add|ls|remove] commands don't return shell Aug 9, 2022
shortthefomo added a commit to shortthefomo/hermes that referenced this issue Aug 31, 2022
@shortthefomo
fix yarn peer [add|ls|remove] commands dont return shell xrpscan#6
cafd217
@shortthefomo shortthefomo mentioned this issue Aug 31, 2022
Merged
@pkcs8 pkcs8 closed this as completed in #26 Sep 16, 2022
pkcs8 pushed a commit that referenced this issue Sep 16, 2022
@shortthefomo
fix yarn peer [add|ls|remove] commands dont return shell #6 (#26)
bdd8cfe
pkcs8 added a commit that referenced this issue Oct 6, 2022
@pkcs8
Fixes #6 - Added mongoose.disconnect in 'npm run peer *' commands
c5c0db3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/return shell shortthefomo/hermes
1 participant
@pkcs8