Skip to content

Conversation

@idpaterson
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • README update
  • Other (export existing code)

🔗 Related issue link

Simplifies my pull request to add a feature to backrest, a project that uses react-js-cron.

💡 Background and solution

The output of parseCronString() is useful for me but currently the only way to get it is through setValuesFromCronString() which would be very cumbersome.

This change simply exports the parseCronString() function with a note in the README. This will allow backrest to avoid an additional cron parsing dependency or the ugly setValuesFromCronString() code linked above.

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Demo in storybook is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests are updated and passed without a decrease in coverage
  • Format (lint & prettier) script passed
  • Build script is working
  • README API section is updated or not needed

@xrutayisire xrutayisire merged commit 2f4b68d into xrutayisire:master Apr 18, 2025
3 checks passed
@xrutayisire
Copy link
Owner

Thank you for the PR, doing a new release now 🚀

@xrutayisire
Copy link
Owner

xrutayisire commented Apr 18, 2025

Released in https://github.com/xrutayisire/react-js-cron/releases/tag/v5.2.0 🚀

@idpaterson
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants