Join GitHub today
Add a command line option to make warnings fatal (Default off) #43
The only thing I would change is removing the "not recommended" comment.
It's less about what whether you have dependencies, but more of whether others depend on you, which makes the comment incorrect.
I think making it non-default basically says we would prefer you wouldn't use fatal warnings.
I don't mind removing the "not recommended" comment, from the short options description, but I think that this option would benefit from a longer explanation somewhere else, with links to the blog posts from Peter Rabbitson and chromatic, to explain more fully why fatal warnings are a bad idea. Question is where?
In any case, I need to add an entry to the changelog about this change, as it does change the public API. I also need to add changelog entries for the other changes I have pushed recently.
Seeing as this change affects the default behaviour of the module, I think the change should be prominently documented somewhere. Also some people will think that the new default is wrong and that best practice is to make warnings fatal.
My thinking is to add a couple of paragraphs to the main POD for the module along the lines of:
"Older versions of this module generated code that made warnings fatal [...] This is no longer the default, see option [...], See blog posts [link] and [link] for reasons why." [Summary explanation]
Would you mind if I made a post to the CPAN PR challenge mailing list about this?