New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple authors to Module::Starter; Issue #25 #55

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@mcmillhj

mcmillhj commented Nov 29, 2015

The included changes add support for multiple authors to Module::Starter and propogate to the chosen builder option. To do this, it seemed appropriate to remove the --email option and ask that users' specify both the author name and email as a single option, which most of the builders expect anyway:

module-starter --module=Foo::Bar,Foo::Bat \
    --author="Andy Lester <andy@petdance.com> \
    --author="Sawyer X <sawyerx@cpan.org>

The attribute that previously held the author, $self->{author} now holds an arrayref of authoremails. Which are passed in turn to Module::Build and ExtUtils::MakeMaker as arrayrefs and to Module::Install as a string.

I tried to follow the existing conventions that were used within the module, but please let me know if I missed anything and/or there are other change you would like me to make.

Add support for multiple authors to Module::Starter; Issue #25
The included changes add support for multiple authors to Module::Starter and propogate to the chosen builder option. To do this, it seemed appropriate to remove the --email option and ask that users' specify both the author name and email as a single option, which most of the builders expect anyway:

    module-starter --module=Foo::Bar,Foo::Bat \
        --author="Andy Lester <andy@petdance.com> \
        --author="Sawyer X <sawyerx@cpan.org>

The attribute that previously held the author, `$self->{author}` now holds an arrayref of authoremails. Which are passed in turn to Module::Build and ExtUtils::MakeMaker as arrayrefs and to Module::Install as a string.

I tried to follow the existing conventions that were used within the module, but please let me know if I missed anything and/or there are other change you would like me to make.
@mcmillhj

This comment has been minimized.

Show comment
Hide comment
@mcmillhj

mcmillhj Nov 29, 2015

This PR is in reference to Issue #25

mcmillhj commented Nov 29, 2015

This PR is in reference to Issue #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment